Skip to content

🎨 Add type and template_type query parameter filter to projects:search endpoint #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 27, 2025
Merged

🎨 Add type and template_type query parameter filter to projects:search endpoint #7995

merged 7 commits into from
Jun 27, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 26, 2025 •
edited
Loading

What do these changes do?

  • Add type and template_type query parameter filter to projects:search endpoint (the same way as it is in /projects endpoint)

Related issue/s

How to test

  • Copilot helped me creating tests in services/web/server/tests/unit/with_dbs/04/workspaces/test_workspaces__list_projects_full_search.py

Dev-ops

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Allow full search for templates 🎨 Add type and template_type query parameter filter to projects:search endpoint Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (1598ada) to head (b46c7f0).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7995      +/-   ##
==========================================
- Coverage   86.11%   85.01%   -1.10%     
==========================================
  Files        1256      696     -560     
  Lines       51637    32793   -18844     
  Branches      481      176     -305     
==========================================
- Hits        44466    27879   -16587     
+ Misses       7037     4856    -2181     
+ Partials      134       58      -76
Flag Coverage Δ
integrationtests 64.22% <66.66%> (+0.41%) ⬆️
unittests 86.87% <100.00%> (+2.81%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.98% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.70% <ø> (-12.75%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.66% <100.00%> (+6.59%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1598ada...b46c7f0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 27, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jun 27, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jun 27, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 27, 2025 11:59
odeimaiz
odeimaiz approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Jun 27, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 27, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sanderegg
sanderegg approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 27, 2025 12:42
@matusdrobuliak66 matusdrobuliak66 merged commit 6b1b81e into ITISFoundation:master Jun 27, 2025
95 of 97 checks passed
@odeimaiz odeimaiz mentioned this pull request Jun 30, 2025
Merged
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @giancarloromeo @odeimaiz @sanderegg